Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed writing nested parquet #1390

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Fixed writing nested parquet #1390

merged 5 commits into from
Feb 10, 2023

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Feb 10, 2023

This PR fixes the writing of repetition and definition levels of nested structures in parquet.

Closes #1368
Closes #1376
Closes #1249
Closes #1356

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 83.37% // Head: 83.49% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (c36bd86) compared to base (ac28bc9).
Patch coverage: 99.13% of modified lines in pull request are covered.

❗ Current head c36bd86 differs from pull request most recent head 971d223. Consider uploading reports for the commit 971d223 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
+ Coverage   83.37%   83.49%   +0.12%     
==========================================
  Files         373      373              
  Lines       40398    40739     +341     
==========================================
+ Hits        33682    34016     +334     
- Misses       6716     6723       +7     
Impacted Files Coverage Δ
src/io/parquet/write/nested/rep.rs 99.00% <98.76%> (-0.48%) ⬇️
src/io/parquet/write/nested/def.rs 99.20% <99.33%> (-0.06%) ⬇️
src/io/ipc/read/file.rs 96.87% <0.00%> (-0.90%) ⬇️
src/io/ipc/read/common.rs 94.90% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit 73b47f1 into main Feb 10, 2023
@jorgecarleitao jorgecarleitao deleted the new_test branch February 10, 2023 21:44
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
1 participant