Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in writing sliced binary #1391

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Fixed error in writing sliced binary #1391

merged 1 commit into from
Feb 11, 2023

Conversation

jorgecarleitao
Copy link
Owner

Fixed minor bug introduced by #1355

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 83.48% // Head: 83.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a06af1b) compared to base (73b47f1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         373      373           
  Lines       40759    40758    -1     
=======================================
+ Hits        34026    34028    +2     
+ Misses       6733     6730    -3     
Impacted Files Coverage Δ
src/io/parquet/write/binary/nested.rs 95.23% <ø> (-0.12%) ⬇️
src/io/ipc/read/array/boolean.rs 92.45% <0.00%> (-5.67%) ⬇️
src/io/ipc/read/file.rs 97.32% <0.00%> (+0.44%) ⬆️
src/bitmap/immutable.rs 86.66% <0.00%> (+0.60%) ⬆️
src/array/binary/mod.rs 92.12% <0.00%> (+1.18%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit 7be484e into main Feb 11, 2023
@jorgecarleitao jorgecarleitao deleted the fix_slice_binary branch February 11, 2023 07:13
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Feb 11, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant