Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added cast for FixedSizeBinary to (Large)Binary #1403

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

ritchie46
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 83.63% // Head: 83.60% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (85eb6be) compared to base (3a8da98).
Patch coverage: 80.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   83.63%   83.60%   -0.04%     
==========================================
  Files         373      373              
  Lines       40284    40326      +42     
==========================================
+ Hits        33692    33714      +22     
- Misses       6592     6612      +20     
Impacted Files Coverage Δ
src/io/parquet/read/statistics/mod.rs 87.31% <14.28%> (-1.30%) ⬇️
src/compute/cast/mod.rs 93.08% <73.33%> (-0.43%) ⬇️
src/io/parquet/read/deserialize/simple.rs 83.03% <82.35%> (-2.07%) ⬇️
src/compute/cast/binary_to.rs 88.59% <100.00%> (+2.88%) ⬆️
src/chunk.rs 83.33% <0.00%> (-7.15%) ⬇️
src/bitmap/utils/slice_iterator.rs 97.56% <0.00%> (-1.22%) ⬇️
src/io/parquet/write/mod.rs 87.83% <0.00%> (-0.25%) ⬇️
src/io/ipc/read/file.rs 96.87% <0.00%> (+0.44%) ⬆️
src/array/utf8/mutable.rs 86.43% <0.00%> (+1.09%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @ritchie46 ! Looks great; left minor comments / suggestions but feel free to merge it as is.

src/array/fixed_size_binary/mod.rs Outdated Show resolved Hide resolved
src/compute/cast/binary_to.rs Outdated Show resolved Hide resolved
src/compute/cast/binary_to.rs Outdated Show resolved Hide resolved
src/compute/cast/binary_to.rs Outdated Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title feat: add cast for FixedSizeBinary to (Large)Binary Added cast for FixedSizeBinary to (Large)Binary Feb 14, 2023
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 14, 2023
@jorgecarleitao jorgecarleitao merged commit 653d57a into jorgecarleitao:main Feb 15, 2023
jgmartin pushed a commit to jgmartin/arrow2 that referenced this pull request Feb 22, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants