This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed statistics writing flag and correct null_count in dictionaries #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
ritchie46
commented
Feb 22, 2023
| @@ -591,7 +591,7 @@ pub fn pyarrow_nullable_statistics(column: &str) -> Statistics { | |||
|
|
|||
| Statistics { | |||
| distinct_count: UInt64Array::from([None]).boxed(), | |||
| null_count: UInt64Array::from([Some(0)]).boxed(), | |||
| null_count: UInt64Array::from([Some(1)]).boxed(), | |||
There was a problem hiding this comment.
This test result was invalid. I debugged and clearly found null_count of 1.
Codecov ReportBase: 83.61% // Head: 83.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 83.61% 83.65% +0.03%
==========================================
Files 373 373
Lines 40326 40340 +14
==========================================
+ Hits 33720 33747 +27
+ Misses 6606 6593 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jorgecarleitao
changed the title
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the parquet writer respects the
write_statistics==falseoption. It also corrects thenull_count. The reported null count was that of the dictionary values instead of the dictionary array.