This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support for JSON serialization of dictionary #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
+ Coverage 83.63% 83.66% +0.02%
==========================================
Files 374 374
Lines 40603 40626 +23
==========================================
+ Hits 33959 33988 +29
+ Misses 6644 6638 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jorgecarleitao
changed the title
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a selfish PR with regard to how many branches are implemented. Given the many combinations of key, value types that can be there, I'd like to have them under a feature flag.
Currently we don't do this yet in arrow2 for dtypes, but given there are many of them I believe there is merit to cherry pick them as we are not light to compile.