This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added impl_mutable_array_mut_validity macro for mutable arrays #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arty-Maly
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
=======================================
Coverage 83.76% 83.77%
=======================================
Files 375 375
Lines 41024 41038 +14
=======================================
+ Hits 34364 34379 +15
+ Misses 6660 6659 -1
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Arty-Maly
force-pushed
the
binary_arrray_apply_validity
branch
from
470f0d3 to
fcfad02
Compare
Arty-Maly
changed the title
Arty-Maly
force-pushed
the
binary_arrray_apply_validity
branch
2 times, most recently
from
db39641 to
e257551
Compare
Arty-Maly
changed the title
|
@jorgecarleitao I seem to be not able to figure out this IPC test failure, I even reverted my changes and ran it and it still failed. Can you give me some direction to debug this? |
Arty-Maly
force-pushed
the
binary_arrray_apply_validity
branch
from
e257551 to
db87f71
Compare
…ly_validity and with_validity
Arty-Maly
force-pushed
the
binary_arrray_apply_validity
branch
from
91ce393 to
fedb075
Compare
jorgecarleitao
changed the title
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding
set_validity,apply_validity, andwith_validityto mutable binary arrays.I am using a macro so it can be reused for other mutable arrays.
The macro for immutable arrays is called:
impl_mut_validityso I tried sticking with that convention and called itimpl_mutable_array_mut_validityBut if there is a better name to describe this macro I will take it.