Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Support nested decimal read write #1553

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Conversation

ariesdevil
Copy link
Contributor

No description provided.

@sundy-li
Copy link
Collaborator

Any tests about this change?

@ariesdevil
Copy link
Contributor Author

Any tests about this change?↳

Noop, there are no related tests for nested read/write :(

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 49.19% and project coverage change: -0.29% ⚠️

Comparison is base (ba6a882) 83.34% compared to head (7cd89f3) 83.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
- Coverage   83.34%   83.06%   -0.29%     
==========================================
  Files         388      389       +1     
  Lines       42212    42581     +369     
==========================================
+ Hits        35183    35368     +185     
- Misses       7029     7213     +184     
Files Changed Coverage Δ
src/io/parquet/write/mod.rs 77.06% <30.50%> (-11.26%) ⬇️
src/io/parquet/read/deserialize/nested.rs 67.00% <56.29%> (-4.10%) ⬇️
...rquet/read/deserialize/fixed_size_binary/nested.rs 57.75% <57.75%> (ø)
...arquet/read/deserialize/fixed_size_binary/basic.rs 94.91% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariesdevil ariesdevil requested a review from b41sh August 28, 2023 09:49
@ariesdevil
Copy link
Contributor Author

@sundy-li add some tests, PTAL

Copy link
Contributor

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundy-li sundy-li requested a review from ritchie46 August 28, 2023 23:40
@sundy-li sundy-li merged commit f609d0c into jorgecarleitao:main Aug 29, 2023
@ariesdevil ariesdevil deleted the decimal branch August 29, 2023 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants