Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix generic parameter in lexsort usage in benches #227

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

sundy-li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #227 (0eab705) into main (7dd1cff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         229      229           
  Lines       19529    19529           
=======================================
  Hits        15025    15025           
  Misses       4504     4504           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd1cff...0eab705. Read the comment docs.

@ritchie46
Copy link
Collaborator

This is a fix for the benches that don't run on main.

@sundy-li
Copy link
Collaborator Author

This is a fix for the benches that don't run on main.

Thanks for the advice, but better to fix this if we need run some bench tests.

@Dandandan Dandandan changed the title generic lexsort usage in benches Fix generic parameter in lexsort usage in benches Jul 29, 2021
@Dandandan Dandandan merged commit b3e4c2c into jorgecarleitao:main Jul 29, 2021
@Dandandan
Copy link
Collaborator

Went ahead and merged this. Thanks @sundy-li

ives9638 added a commit to ives9638/arrow2 that referenced this pull request Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants