Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Short-circuited boolean evaluation in GrowableList #228

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

ritchie46
Copy link
Collaborator

If the argument use_validity is set to true the checks for null count are redundant. This PR makes that the check is skipped in that case.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #228 (0c0595f) into main (7dd1cff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         229      229           
  Lines       19529    19529           
=======================================
  Hits        15025    15025           
  Misses       4504     4504           
Impacted Files Coverage Δ
src/array/growable/list.rs 98.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd1cff...0c0595f. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 95fe10a into jorgecarleitao:main Jul 29, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 29, 2021
@jorgecarleitao jorgecarleitao changed the title don't check if use_validity==true Short-circuited boolean evaluation in GrowableList Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants