Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made IPC integration tests run tests that are not run by arrow-rs #278

Merged
merged 2 commits into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/integration-ipc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:
# which is incompatible with this. Let's monkey patch it
- name: Fix compilation
run: cp rust/integration-testing/rust_build.sh ci/scripts/rust_build.sh
# unskip many of the tests
- name: Test more cases
run: git apply rust/integration-testing/unskip.patch
- name: Setup Python
uses: actions/setup-python@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion integration-testing/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ publish = false
logging = ["tracing-subscriber"]

[dependencies]
arrow2 = { path = "../", features = ["io_ipc", "io_json_integration"], default-features = false }
arrow2 = { path = "../", features = ["io_ipc", "io_ipc_compression", "io_json_integration"], default-features = false }
arrow-flight = { path = "../arrow-flight" }
async-trait = "0.1.41"
clap = "2.33"
Expand Down
40 changes: 40 additions & 0 deletions integration-testing/unskip.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
diff --git a/dev/archery/archery/integration/datagen.py b/dev/archery/archery/integration/datagen.py
index d0c4b3d6c..bc4b83e68 100644
--- a/dev/archery/archery/integration/datagen.py
+++ b/dev/archery/archery/integration/datagen.py
@@ -1568,8 +1568,7 @@ def get_generated_json_files(tempdir=None):
.skip_category('Go') # TODO(ARROW-7901)
.skip_category('JS'), # TODO(ARROW-7900)

- generate_decimal128_case()
- .skip_category('Rust'),
+ generate_decimal128_case(),

generate_decimal256_case()
.skip_category('Go') # TODO(ARROW-7948): Decimal + Go
@@ -1579,8 +1578,7 @@ def get_generated_json_files(tempdir=None):
generate_datetime_case(),

generate_interval_case()
- .skip_category('JS') # TODO(ARROW-5239): Intervals + JS
- .skip_category('Rust'),
+ .skip_category('JS'), # TODO(ARROW-5239): Intervals + JS

generate_month_day_nano_interval_case()
.skip_category('Go')
@@ -1603,13 +1601,11 @@ def get_generated_json_files(tempdir=None):

generate_nested_large_offsets_case()
.skip_category('Go')
- .skip_category('JS')
- .skip_category('Rust'),
+ .skip_category('JS'),

generate_unions_case()
.skip_category('Go')
- .skip_category('JS')
- .skip_category('Rust'),
+ .skip_category('JS'),

generate_custom_metadata_case()
.skip_category('JS'),