Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

add a test case of incorrect merge sort #325

Closed

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Aug 24, 2021

@sundy-li sundy-li changed the title use a test case of incorrect merge sort add a test case of incorrect merge sort Aug 24, 2021
@jorgecarleitao jorgecarleitao self-assigned this Aug 24, 2021
@jorgecarleitao
Copy link
Owner

found the root cause, fixing it

@jorgecarleitao
Copy link
Owner

This is fixed by #327

@jorgecarleitao
Copy link
Owner

Thanks a lot for taking the time to write a minimal test case; very useful! (also glad that you are using the merge-sort compute kernel; was not sure if it would ever be used ^_^)

@sundy-li
Copy link
Collaborator Author

Thanks a lot for taking the time to write a minimal test case; very useful! (also glad that you are using the merge-sort compute kernel; was not sure if it would ever be used ^_^)

Thanks for the fix. The merge-sort kernel is useful, and it also can be optimized by heap-sort when the limit option is very small (holding a priority queue in memory to reduce the compare times). I've created an issue in #329 to track it.

@sundy-li sundy-li closed this Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants