This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
Added support to read dict-encoded required primitive types from parquet #402
Merged
jorgecarleitao
merged 5 commits into
jorgecarleitao:main
from
Dandandan:read_dict_buffer_required
Sep 13, 2021
Merged
Added support to read dict-encoded required primitive types from parquet #402
jorgecarleitao
merged 5 commits into
jorgecarleitao:main
from
Dandandan:read_dict_buffer_required
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 80.90% 80.91% +0.01%
==========================================
Files 347 347
Lines 22086 22098 +12
==========================================
+ Hits 17869 17881 +12
Misses 4217 4217
Continue to review full report at Codecov.
|
Awesome! I think we are just missing a small test here. I have been using
I think 1. and 2. are done, we just need to add something like #[test]
fn v2_int64_required_dict() -> Result<()> {
test_pyarrow_integration(0, 2, "basic", true, true)
}
#[test]
fn v1_int64_required_dict() -> Result<()> {
test_pyarrow_integration(0, 1, "basic", true, true)
} to check that we can read parquet files written by |
jorgecarleitao
changed the title
Implement read_dict_buffer_required
Added support to read dict-encoded non-null primitive types
Sep 13, 2021
jorgecarleitao
changed the title
Added support to read dict-encoded non-null primitive types
Added support to read dict-encoded non-null primitive types from parquet
Sep 13, 2021
jorgecarleitao
changed the title
Added support to read dict-encoded non-null primitive types from parquet
Added support to read dict-encoded required primitive types from parquet
Sep 13, 2021
Released in v0.5.3. |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400