Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added reading of parquet required dictionary-encoded binary. #419

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jorgecarleitao
Copy link
Owner

Closes #418.

Thanks @Dandandan for flagging this!

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 17, 2021
Copy link
Collaborator

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! - LGTM

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #419 (d086cc8) into main (d5cc0db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   80.96%   80.98%   +0.01%     
==========================================
  Files         347      347              
  Lines       22201    22221      +20     
==========================================
+ Hits        17976    17996      +20     
  Misses       4225     4225              
Impacted Files Coverage Δ
src/io/parquet/read/binary/basic.rs 84.10% <100.00%> (+2.15%) ⬆️
tests/it/io/parquet/read.rs 98.55% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cc0db...d086cc8. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Added support for required dict utf8 read. Added support for reading parquet required dict binary. Sep 17, 2021
@jorgecarleitao jorgecarleitao changed the title Added support for reading parquet required dict binary. Added reading of parquet required dictionary-encoded binary. Sep 17, 2021
@jorgecarleitao jorgecarleitao merged commit aee8124 into main Sep 17, 2021
@jorgecarleitao jorgecarleitao deleted the parquet_dict_required branch September 17, 2021 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dictionary required for binary parquet data
2 participants