Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved performance of PrimitiveGrowable for nulls (-10%) #434

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

jorgecarleitao
Copy link
Owner

  • Added docs
  • standardized design on extending nulls (-10% for primitive arrays)

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #434 (3df71cd) into main (24f6194) will increase coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   80.78%   80.84%   +0.05%     
==========================================
  Files         372      372              
  Lines       22645    22729      +84     
==========================================
+ Hits        18294    18375      +81     
- Misses       4351     4354       +3     
Impacted Files Coverage Δ
src/array/growable/binary.rs 94.73% <ø> (ø)
src/array/growable/boolean.rs 81.48% <ø> (ø)
src/array/growable/fixed_binary.rs 68.75% <ø> (ø)
src/array/growable/list.rs 96.61% <ø> (ø)
src/array/growable/mod.rs 48.00% <ø> (ø)
src/array/growable/null.rs 53.84% <ø> (ø)
src/array/growable/structure.rs 88.23% <ø> (ø)
src/array/growable/utf8.rs 100.00% <ø> (ø)
src/array/growable/utils.rs 100.00% <ø> (ø)
src/array/growable/dictionary.rs 69.56% <75.00%> (+2.89%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f6194...3df71cd. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Improved growable. Improved performance of PrimitiveGrowable for nulls (-10%) Sep 22, 2021
@jorgecarleitao jorgecarleitao merged commit cdbc958 into main Sep 22, 2021
@jorgecarleitao jorgecarleitao deleted the growable branch September 22, 2021 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant