This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Un-nested compute::arithemtics::basic
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
force-pushed
the
unested
branch
2 times, most recently
from
32d8711 to
43a17c5
Compare
jorgecarleitao
changed the title
compute::arithemtics::basic
jorgecarleitao
force-pushed
the
unested
branch
2 times, most recently
from
7f3b23d to
1952ddb
Compare
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 371 371
Lines 22839 22839
=======================================
+ Hits 18279 18280 +1
+ Misses 4560 4559 -1
Continue to review full report at Codecov.
|
jorgecarleitao
force-pushed
the
unested
branch
from
1952ddb to
b28fd99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the modules
compute::arithmetics::basic::*from the public API, instead re-exporting all functions on them tocompute::arithmetics::basic, making them a bit easier to find and use.To migrate, replace
compute::arithmetics::basic::add,compute::arithmetics::basic::sub, etc. bycompute::arithmetics::basic.