Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Revert "Fixed ffi of sliced arrays (#540)" #552

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

This reverts commit e6b6c83.

It introduced a regression in other parts of the code that is worse than fixing the FFI. Need to re-think it :P

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #552 (24851fa) into main (4491954) will decrease coverage by 0.26%.
The diff coverage is 46.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   79.38%   79.11%   -0.27%     
==========================================
  Files         384      382       -2     
  Lines       24354    24389      +35     
==========================================
- Hits        19333    19296      -37     
- Misses       5021     5093      +72     
Impacted Files Coverage Δ
src/array/boolean/ffi.rs 0.00% <0.00%> (ø)
src/array/ffi.rs 65.00% <ø> (-5.00%) ⬇️
src/array/map/ffi.rs 0.00% <0.00%> (ø)
src/array/map/mod.rs 40.00% <0.00%> (-0.68%) ⬇️
src/array/null.rs 39.28% <0.00%> (-4.72%) ⬇️
src/array/struct_.rs 43.20% <0.00%> (-19.95%) ⬇️
src/array/union/ffi.rs 0.00% <0.00%> (ø)
src/array/fixed_size_binary/mod.rs 50.00% <14.28%> (-3.74%) ⬇️
src/array/fixed_size_list/mod.rs 59.70% <14.28%> (-5.30%) ⬇️
src/array/dictionary/mod.rs 46.66% <50.00%> (-10.23%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4491954...24851fa. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant