Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Introduced UnionMode enum #557

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

simonvandel
Copy link
Contributor

I feel like seeing UnionMode::Sparse is easier than true

I feel like seeing `UnionMode::Sparse` is easier than `true`
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Looks great. Thanks!

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #557 (bbb7c9c) into main (5fc843d) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   78.92%   78.93%           
=======================================
  Files         382      382           
  Lines       24276    24291   +15     
=======================================
+ Hits        19160    19173   +13     
- Misses       5116     5118    +2     
Impacted Files Coverage Δ
src/ffi/schema.rs 65.15% <0.00%> (ø)
src/io/avro/read/schema.rs 52.38% <0.00%> (ø)
src/io/ipc/read/array/union.rs 76.74% <50.00%> (+1.74%) ⬆️
src/datatypes/mod.rs 77.33% <75.00%> (-0.28%) ⬇️
src/array/union/mod.rs 79.41% <88.88%> (-0.20%) ⬇️
src/io/ipc/convert.rs 92.46% <100.00%> (ø)
src/io/json_integration/schema.rs 46.05% <100.00%> (ø)
tests/it/array/mod.rs 100.00% <100.00%> (ø)
tests/it/array/union.rs 100.00% <100.00%> (ø)
tests/it/io/print.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc843d...bbb7c9c. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Introduce UnionMode enum Introduced UnionMode enum Oct 30, 2021
@jorgecarleitao jorgecarleitao merged commit cdcf150 into jorgecarleitao:main Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants