This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Avoided redundant checks in creating an Utf8Array
from MutableUtf8Array
#560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a performance issue when creating
Utf8Array
fromMutableUtf8Array
: sinceMutableUtf8Array
has the same invariants asUtf8Array
, we can usefrom_data_unchecked
, avoiding re-running expensive utf8 validation.