Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified IPC APIs #576

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Simplified IPC APIs #576

merged 1 commit into from
Nov 5, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Nov 4, 2021

This PR removes old functionality to write to legacy versions of the IPC format. V5 is quite standard at this point in time by now.

This also simplifies the write options for IPC, removing unused options and making all options explicit.

Backward incompatible changes

To migrate to the new API:

  • pass the write options to StreamWriter::try_new and FileWriter::try_new
  • Rename IpcWriteOptions to WriteOptions
  • Initialize WriteOptions using WriteOptions { compression }

Deprecated

  • option ipc_legacy_format: we no longer support that
  • option alignment: this was not even correct AFAIK, since it was not consistent across the module.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #576 (010b1d2) into main (0dda942) will increase coverage by 0.06%.
The diff coverage is 72.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   78.88%   78.94%   +0.06%     
==========================================
  Files         395      395              
  Lines       24678    24640      -38     
==========================================
- Hits        19467    19452      -15     
+ Misses       5211     5188      -23     
Impacted Files Coverage Δ
src/io/flight/mod.rs 0.00% <0.00%> (ø)
src/io/ipc/write/writer.rs 87.71% <77.77%> (+4.11%) ⬆️
src/io/ipc/write/common.rs 94.77% <100.00%> (+10.11%) ⬆️
src/io/ipc/write/schema.rs 100.00% <100.00%> (ø)
src/io/ipc/write/stream.rs 72.00% <100.00%> (+4.14%) ⬆️
src/io/parquet/write/schema.rs 62.67% <100.00%> (ø)
tests/it/io/ipc/write/file.rs 100.00% <100.00%> (ø)
tests/it/io/ipc/write/stream.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dda942...010b1d2. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 83d828c into main Nov 5, 2021
@jorgecarleitao jorgecarleitao deleted the ipc_simpler branch November 5, 2021 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant