Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Macro natives and linting #6

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

elferherrera
Copy link
Contributor

While I was studying you code I found several lint hints that could be applied to your code. I hope you find them useful and want to integrate to your branch

@jorgecarleitao
Copy link
Owner

Hi @elferherrera ; thanks a lot! Could you describe the process over which you found them? It would be advantageous to place it on the CI.

@jorgecarleitao jorgecarleitao merged commit 7733d92 into jorgecarleitao:main Mar 11, 2021
@elferherrera
Copy link
Contributor Author

elferherrera commented Mar 11, 2021

If you are using vscode and rust analyzer you will get these suggestions for free. I used to use nvim but I couldn't get the suggestions to work as well as they work in vscode. In the past month I have been coding with vscode and it has helped me a lot.

You can find the same suggestions using cargo clippy. In the code there are still 25 warnings if you run clippy. I didn't change them all because I think you would need to see if they make sense. These include functions with too many arguments, or to replace while let for a for loop, or to add safety explanations in unsafe code.

Btw, if you dont mind, I would like to help you adding more documentation to your repo while it gets moved to the main arrow repo.

I was also wondering if it is a good idea to merge the guide Im working on with yours when this crate gets joined, what do you think?

@elferherrera elferherrera deleted the macro_natives branch March 11, 2021 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants