This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Operator
and replaces it by different function calls as proposed by #527 . This does not close that issue yet because a similar PR is necessary for the arithmetic kernels.Backward incompatible changes
This PR removes the enum
Operator
incompute::comparison
. Instead, the API is composed bythe functions inside each
X
are statically-typed (e.g. expectUtf8Array
), while the functionsarrow2::compute::comparison::Y
are dynamically-typed (i.e. expectArray
andScalar
).As usual, each dynamic variant contains a
can_Y(&DataType)
that returns whether the operation is valid / is implemented.Also, the functions no longer return a
Result
and instead simply panic; this is because:can_Y
, which users can use to check whether the operation will panic or not.This simplifies the overall API and allows implementing equality to types that have no partial or total order defined.