Avoid double utf8 checks on MutableUtf8 -> Utf8

.github/workflows/security.yml

@@ -25,6 +25,8 @@ jobs:
           toolchain: nightly-2021-10-24
           override: true
       - uses: Swatinem/rust-cache@v1
+        with:
+          key: key1
       - name: Install Miri
         run: |
           rustup component add miri

.github/workflows/test.yml

@@ -77,6 +77,8 @@ jobs:
           toolchain: nightly-2021-10-24
           override: true
       - uses: Swatinem/rust-cache@v1
+        with:
+          key: key1
       - name: Install Miri
         run: |
           rustup component add miri
@@ -96,6 +98,8 @@ jobs:
           toolchain: nightly-2021-10-24
           override: true
       - uses: Swatinem/rust-cache@v1
+        with:
+          key: key1
       - name: Install Miri
         run: |
           rustup component add miri

src/array/utf8/mutable.rs

@@ -201,21 +201,31 @@ impl<O: Offset> MutableArray for MutableUtf8Array<O> {
     }
 
     fn as_box(&mut self) -> Box<dyn Array> {
-        Box::new(Utf8Array::from_data(
-            Self::default_data_type(),
-            std::mem::take(&mut self.offsets).into(),
-            std::mem::take(&mut self.values).into(),
-            std::mem::take(&mut self.validity).map(|x| x.into()),
-        ))
+        // Safety:
+        // `MutableUtf8Array` has the same invariants as `Utf8Array` and thus
+        // `Utf8Array` can be safely created from `MutableUtf8Array` without checks.
+        Box::new(unsafe {
+            Utf8Array::from_data_unchecked(
+                self.data_type.clone(),
+                std::mem::take(&mut self.offsets).into(),
+                std::mem::take(&mut self.values).into(),
+                std::mem::take(&mut self.validity).map(|x| x.into()),
+            )
+        })
     }
 
     fn as_arc(&mut self) -> Arc<dyn Array> {
-        Arc::new(Utf8Array::from_data(
-            Self::default_data_type(),
-            std::mem::take(&mut self.offsets).into(),
-            std::mem::take(&mut self.values).into(),
-            std::mem::take(&mut self.validity).map(|x| x.into()),
-        ))
+        // Safety:
+        // `MutableUtf8Array` has the same invariants as `Utf8Array` and thus
+        // `Utf8Array` can be safely created from `MutableUtf8Array` without checks.
+        Arc::new(unsafe {
+            Utf8Array::from_data_unchecked(
+                self.data_type.clone(),
+                std::mem::take(&mut self.offsets).into(),
+                std::mem::take(&mut self.values).into(),
+                std::mem::take(&mut self.validity).map(|x| x.into()),
+            )
+        })
     }
 
     fn data_type(&self) -> &DataType {
@@ -359,7 +369,7 @@ impl<O: Offset> MutableUtf8Array<O> {
         Self::from_data_unchecked(Self::default_data_type(), offsets, values, None)
     }
 
-    /// Creates a new [`Utf8Array`] from a [`TrustedLen`] of `&str`.
+    /// Creates a new [`MutableUtf8Array`] from a [`TrustedLen`] of `&str`.
     #[inline]
     pub fn from_trusted_len_values_iter<T: AsRef<str>, I: TrustedLen<Item = T>>(
         iterator: I,