Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix bug related to Decimal negative value support #684

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix bug related to Decimal negative value support #684

merged 1 commit into from
Dec 14, 2021

Conversation

mdrach
Copy link
Contributor

@mdrach mdrach commented Dec 14, 2021

This corrects a bug introduced in #679 , which resolves #676. The bug was caused by some confusion over endianness.

@mdrach mdrach changed the title fixed MSB selector Fixed bug related to Decimal negative value support Dec 14, 2021
@mdrach mdrach changed the title Fixed bug related to Decimal negative value support Fix bug related to Decimal negative value support Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #684 (b5c4184) into main (fdb8c68) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   69.76%   69.77%   +0.01%     
==========================================
  Files         303      303              
  Lines       16830    16830              
==========================================
+ Hits        11741    11743       +2     
+ Misses       5089     5087       -2     
Impacted Files Coverage Δ
src/io/parquet/read/mod.rs 44.76% <100.00%> (ø)
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb8c68...b5c4184. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 565cfae into jorgecarleitao:main Dec 14, 2021
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet reading cannot handle negative values of type Decimal
2 participants