This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
and_scalar
andor_scalar
for boolean #707Added
and_scalar
andor_scalar
for boolean #707Changes from 3 commits
be45566
6fb5088
958f3a9
4dfbe3f
ad36ece
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this
or
version, I want to initialize a Bitmap with alltrue
bits to implementA | true = true
. Is that right? Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes, you are right!
Unfortunately we do not have a specific method for that, but it is worth checking
MutableBitmap::extend_constant
here, since it sets 8 bits per write, still much faster thanfrom_trusted_len_iter
^_^There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, the reason we have all these seemly similar APIs is that for a single API (like rust's
Vec::extend
) we need trait specialization in the stable channel. This is why we currently name every method differently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for instruction. I updated to use
MutableBitmap:: extend_constant
. Thanks.