This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
bytemuck
dependency and replaces all instances ofunsafe
in the IO module bybytemuck
's API, also adding#[forbid(unsafe)]
to make it more explicit that our IO has nounsafe
on it.It has no performance implications, it just formalizes (in traits) our use of plain old data (Pod) as defined in
bytemuck
.Thanks to the wg secure code and in particular to @Shnatsel and @tarcieri for the recommendation that led to this PR, and also to the folks at
#dark-arts
for confirming that the two implementations ofPod
in this PR are sound.