Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Refactored nullif #753

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Refactored nullif #753

merged 1 commit into from
Jan 11, 2022

Conversation

jorgecarleitao
Copy link
Owner

  • Added nullif to remaining primitives
  • Made nullif panic if invalid arguments (the user can check the compute's capability to know if the dynamic dispatch is available via can_nullif)
  • Renamed nullif_primitive to primitive_nullif to align with the rest of the API
  • Added support to scalar version, nullif_scalar
  • Added primitive_nullif_scalar

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #753 (a764292) into main (2493f7d) will increase coverage by 0.15%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   70.80%   70.96%   +0.15%     
==========================================
  Files         313      313              
  Lines       16930    16896      -34     
==========================================
+ Hits        11988    11990       +2     
+ Misses       4942     4906      -36     
Impacted Files Coverage Δ
src/compute/comparison/mod.rs 39.53% <ø> (ø)
src/compute/nullif.rs 0.00% <0.00%> (ø)
src/compute/utils.rs 95.65% <ø> (+17.08%) ⬆️
src/compute/comparison/primitive.rs 100.00% <100.00%> (ø)
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2493f7d...a764292. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 9afb1ac into main Jan 11, 2022
@jorgecarleitao jorgecarleitao deleted the nullif_scalar branch January 11, 2022 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant