This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Remove un-needed unsafe
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 70.80% 70.79% -0.02%
==========================================
Files 313 313
Lines 16930 17180 +250
==========================================
+ Hits 11988 12163 +175
- Misses 4942 5017 +75
Continue to review full report at Codecov.
|
bytesnail
reviewed
Jan 15, 2022
| let offsets = offsets.iter().map(|x| *x as i64); | ||
| let offets = Buffer::from_trusted_len_iter(offsets); | ||
| let offets = array | ||
| .offsets() |
There was a problem hiding this comment.
let offets = array
would be ?
let offsets = array
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.