Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

More to into_mut implementations #801

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

ritchie46
Copy link
Collaborator

This adds an into_mut for Utf8Array and for BooleanArray.

For ListArray this is not yet possible, we first need an anonymous list builder. I believe we have discussed this earlier but I cannot find the issue.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #801 (dc008bc) into main (777f375) will decrease coverage by 0.21%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   71.50%   71.29%   -0.22%     
==========================================
  Files         321      321              
  Lines       16739    16814      +75     
==========================================
+ Hits        11970    11987      +17     
- Misses       4769     4827      +58     
Impacted Files Coverage Δ
src/array/boolean/mod.rs 57.53% <0.00%> (-24.82%) ⬇️
src/array/utf8/mod.rs 64.17% <28.30%> (-23.48%) ⬇️
src/array/utf8/mutable.rs 81.06% <0.00%> (+0.59%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777f375...dc008bc. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 89d8e09 into jorgecarleitao:main Feb 3, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants