Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved performance of SlicesIterator (15%) #824

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Improved performance of SlicesIterator (15%) #824

merged 2 commits into from
Feb 8, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Feb 7, 2022

Some code simplification (10%) and inlining (5%).

bitmap slices 2^10      time:   [3.3655 us 3.3766 us 3.3875 us]                                
                        change: [-15.754% -15.343% -14.973%] (p = 0.00 < 0.05)

bitmap slices 2^20      time:   [3.3802 ms 3.3890 ms 3.3976 ms]                                
                        change: [-15.120% -14.776% -14.451%] (p = 0.00 < 0.05)

@jorgecarleitao jorgecarleitao changed the title Improved performance of `SlicesIterator (15%) Improved performance of SlicesIterator (15%) Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #824 (05d7ad9) into main (1dd1b19) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   71.63%   71.60%   -0.03%     
==========================================
  Files         326      326              
  Lines       17523    17514       -9     
==========================================
- Hits        12552    12541      -11     
- Misses       4971     4973       +2     
Impacted Files Coverage Δ
src/bitmap/utils/slice_iterator.rs 87.93% <100.00%> (-4.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd1b19...05d7ad9. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit d8093bf into main Feb 8, 2022
@jorgecarleitao jorgecarleitao deleted the bla branch February 8, 2022 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant