Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

DRY parquet reading #845

Merged
merged 3 commits into from
Feb 16, 2022
Merged

DRY parquet reading #845

merged 3 commits into from
Feb 16, 2022

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #845 (e97db83) into main (e0f98c7) will increase coverage by 0.06%.
The diff coverage is 88.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   71.53%   71.59%   +0.06%     
==========================================
  Files         336      335       -1     
  Lines       17802    17791      -11     
==========================================
+ Hits        12735    12738       +3     
+ Misses       5067     5053      -14     
Impacted Files Coverage Δ
src/io/parquet/read/mod.rs 82.40% <ø> (+1.29%) ⬆️
src/io/parquet/read/nested_utils.rs 73.77% <75.00%> (ø)
src/io/parquet/read/primitive/basic.rs 75.55% <75.86%> (-0.54%) ⬇️
src/io/parquet/read/primitive/nested.rs 60.78% <87.50%> (-1.48%) ⬇️
src/io/parquet/read/fixed_size_binary/basic.rs 80.89% <90.47%> (+1.12%) ⬆️
src/io/parquet/read/binary/basic.rs 80.80% <92.00%> (+1.42%) ⬆️
src/io/parquet/read/binary/nested.rs 53.84% <100.00%> (ø)
src/io/parquet/read/boolean/basic.rs 75.47% <100.00%> (-1.32%) ⬇️
src/io/parquet/read/boolean/nested.rs 50.87% <100.00%> (+0.87%) ⬆️
src/io/parquet/read/deserialize/mod.rs 38.41% <100.00%> (+1.34%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f98c7...e97db83. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 6eb0c1d into main Feb 16, 2022
@jorgecarleitao jorgecarleitao deleted the improved_parquet branch February 16, 2022 21:39
sydduckworth pushed a commit to mindx/arrow2 that referenced this pull request Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant