Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for min/max for decimal #897

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

It was missing from the list of supported types, and it is mostly just re-using existing infrastructure.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #897 (1ac1d0a) into main (6ed716e) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
- Coverage   70.29%   70.28%   -0.01%     
==========================================
  Files         343      344       +1     
  Lines       18792    18794       +2     
==========================================
+ Hits        13209    13210       +1     
- Misses       5583     5584       +1     
Impacted Files Coverage Δ
src/compute/aggregate/min_max.rs 65.16% <0.00%> (-0.75%) ⬇️
src/compute/aggregate/simd/native.rs 90.32% <ø> (-3.80%) ⬇️
src/compute/aggregate/simd/mod.rs 100.00% <100.00%> (ø)
src/bitmap/utils/slice_iterator.rs 87.93% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed716e...1ac1d0a. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 3f0983b into main Mar 9, 2022
@jorgecarleitao jorgecarleitao deleted the decimal_min_max branch March 9, 2022 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant