Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

remove csv dependency for csv-write #917

Merged
merged 1 commit into from
Mar 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ io_csv = ["io_csv_read", "io_csv_write"]
io_csv_async = ["io_csv_read_async"]
io_csv_read = ["csv", "lexical-core"]
io_csv_read_async = ["csv-async", "lexical-core", "futures"]
io_csv_write = ["csv", "csv-core", "streaming-iterator", "lexical-core"]
io_csv_write = ["csv-core", "streaming-iterator", "lexical-core"]
io_json = ["serde", "serde_json", "streaming-iterator", "fallible-streaming-iterator", "indexmap", "lexical-core"]
io_ipc = ["arrow-format"]
io_ipc_write_async = ["io_ipc", "futures"]
Expand Down
2 changes: 1 addition & 1 deletion src/io/csv/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mod read_utils;
#[cfg(any(feature = "io_csv_read_async", feature = "io_csv_read"))]
mod utils;

#[cfg(any(feature = "io_csv_read", feature = "io_csv_write"))]
#[cfg(feature = "io_csv_read")]
impl From<csv::Error> for ArrowError {
fn from(error: csv::Error) -> Self {
ArrowError::External("".to_string(), Box::new(error))
Expand Down
3 changes: 0 additions & 3 deletions src/io/csv/write/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ use super::super::iterator::StreamingIterator;

use std::io::Write;

// re-export necessary public APIs from csv
pub use csv::{ByteRecord, WriterBuilder};

pub use serialize::*;

use crate::array::Array;
Expand Down