Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

update to odbc-api 0.36.0 #925

Merged
merged 1 commit into from
Mar 21, 2022
Merged

update to odbc-api 0.36.0 #925

merged 1 commit into from
Mar 21, 2022

Conversation

pacman82
Copy link
Collaborator

Hello Jorge,

this PR handles a breaking change in the newest odbc-api version. AnyColumnView now holds a TextColumnView and BinColumnView. You can get to the old iterator class by calling .iter() on them. This has been introduced to make reading text columns more similar to how other columns work. Also the view intermediare is a good place to have some other helper methods. I added content_length_at in order to figure out the length of the value (in the buffer) at any position and also raw_value_buffer, which allows direct access to the underlying text buffers.

https://docs.rs/odbc-api/latest/odbc_api/buffers/struct.TextColumnView.html

Cheers, Markus

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #925 (2cd73e6) into main (be5c88e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   71.07%   71.07%           
=======================================
  Files         346      346           
  Lines       18932    18932           
=======================================
  Hits        13455    13455           
  Misses       5477     5477           
Impacted Files Coverage Δ
src/io/odbc/read/deserialize.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5c88e...2cd73e6. Read the comment docs.

@pacman82 pacman82 requested a review from jorgecarleitao March 21, 2022 13:04
@jorgecarleitao jorgecarleitao merged commit b62868d into main Mar 21, 2022
@jorgecarleitao jorgecarleitao deleted the update-odbc-api branch March 21, 2022 16:33
@jorgecarleitao
Copy link
Owner

Thanks, @pacman82 ! Makes a lot of sense

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 21, 2022
@pacman82
Copy link
Collaborator Author

Cheers @jorgecarleitao , still busy and currently recovering from Covid, but let me know if any missing features are blocking you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants