This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support for union scalars #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 71.53% 71.49% -0.05%
==========================================
Files 355 357 +2
Lines 19607 19688 +81
==========================================
+ Hits 14026 14076 +50
- Misses 5581 5612 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you, @ncpenke , looks great!
I left some comments as I think we can simplify the scalar further due to the observation that Union does not have a validity - values are always valid.
src/array/union/mod.rs
Outdated
| @@ -296,6 +293,13 @@ impl Array for UnionArray { | |||
| None | |||
| } | |||
|
|
|||
| fn is_valid(&self, index: usize) -> bool { | |||
There was a problem hiding this comment.
is this necessary? A union does not have a "validity". I could not find where this was being used.
|
@jorgecarleitao Latest changes with your feedback - thanks! |
jorgecarleitao
approved these changes
Apr 30, 2022
Co-authored-by: Jorge Leitao <[email protected]>
jorgecarleitao
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.