Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reduced memory usage in reading parquet #964

Merged
merged 1 commit into from
Apr 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/parquet_read.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ fn main() -> Result<()> {
let file_path = &args[1];

let reader = File::open(file_path)?;
let reader = read::FileReader::try_new(reader, Some(&[8]), None, None, None)?;
let reader = read::FileReader::try_new(reader, None, None, None, None)?;

println!("{:#?}", reader.schema());

Expand All @@ -25,8 +25,8 @@ fn main() -> Result<()> {

let start = SystemTime::now();
for maybe_chunk in reader {
let columns = maybe_chunk?;
assert!(!columns.is_empty());
let chunk = maybe_chunk?;
assert!(!chunk.is_empty());
}
println!("took: {} ms", start.elapsed().unwrap().as_millis());
Ok(())
Expand Down
4 changes: 2 additions & 2 deletions src/io/parquet/read/deserialize/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ pub(super) fn extend_from_new_page<'a, T: Decoder<'a>>(
let mut decoded = if let Some(decoded) = items.pop_back() {
// there is a already a state => it must be incomplete...
debug_assert!(
decoded.len() < chunk_size,
decoded.len() <= chunk_size,
"the temp state is expected to be incomplete"
);
decoded
Expand Down Expand Up @@ -435,7 +435,7 @@ pub(super) fn next<'a, I: DataPages, D: Decoder<'a>>(

extend_from_new_page(page, chunk_size, items, decoder);

if items.front().unwrap().len() < chunk_size {
if (items.len() == 1) && items.front().unwrap().len() < chunk_size {
MaybeNext::More
} else {
let decoded = items.pop_front().unwrap();
Expand Down