Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified PageIterator #103

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Simplified PageIterator #103

merged 3 commits into from
Mar 19, 2022

Conversation

jorgecarleitao
Copy link
Owner

  • Renamed it to PageReader
  • Added trait PageIterator
  • Removed internal state for page index, since page indexes are only present in metadata

@codecov-commenter
Copy link

Codecov Report

Merging #103 (5fdb81d) into main (e499570) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   68.08%   68.32%   +0.24%     
==========================================
  Files          72       72              
  Lines        3910     3927      +17     
==========================================
+ Hits         2662     2683      +21     
+ Misses       1248     1244       -4     
Impacted Files Coverage Δ
src/parquet_bridge.rs 23.07% <ø> (+0.57%) ⬆️
src/write/column_chunk.rs 0.00% <ø> (ø)
src/read/compression.rs 79.45% <100.00%> (+0.28%) ⬆️
src/read/mod.rs 93.46% <100.00%> (-0.75%) ⬇️
src/read/page/reader.rs 85.18% <100.00%> (ø)
src/error.rs 20.00% <0.00%> (-2.23%) ⬇️
src/lib.rs 79.20% <0.00%> (+0.48%) ⬆️
src/statistics/binary.rs 5.55% <0.00%> (+5.55%) ⬆️
src/metadata/column_chunk_metadata.rs 63.76% <0.00%> (+13.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e499570...5fdb81d. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit a6e6cf3 into main Mar 19, 2022
dantengsky pushed a commit to datafuse-extras/parquet2 that referenced this pull request Apr 1, 2022
@jorgecarleitao jorgecarleitao deleted the page_reader branch April 22, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants