Fixed design error in filtered pages #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a design mistake in how filtered pages should be represented.
The examples in #102 assumed that a page would only overlap with a single row interval. However, it is possible for multiple row intervals to overlap a single page. The current API in main does not cater for this.
This PR fixes this, therefore closing #102.
Tests demonstrate how a column with pages containing
and the selection
let intervals = &[Interval::new(2, 2)];
(start, length) yieldsvec![None, Some(3)])]
.In this model, we do not decompress nor deserialize page2, and we do not deserialize the remaining items from page1.
Closes #102