Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made offsets be always written #123

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Made offsets be always written #123

merged 1 commit into from
Apr 12, 2022

Conversation

jorgecarleitao
Copy link
Owner

Page offsets do not require statistics and can always be written. Given how important and small they are, let's just write them.

@jorgecarleitao jorgecarleitao added the enhancement New feature or request label Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #123 (286d6c9) into main (2fc0a78) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   74.52%   74.49%   -0.04%     
==========================================
  Files          78       78              
  Lines        3498     3501       +3     
==========================================
+ Hits         2607     2608       +1     
- Misses        891      893       +2     
Impacted Files Coverage Δ
src/write/file.rs 86.07% <85.71%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc0a78...286d6c9. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 03b15a9 into main Apr 12, 2022
@jorgecarleitao jorgecarleitao deleted the filter branch April 12, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants