Removed compression from WriteOptions
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the explicit compression setting in `WriteOptions`. It was somewhat confusing as the pages still needed to be appropriately compressed, and limiting as it forced the same value for the whole file.
|
This is awesome! I will just try to apply on arrow2 to check that it makes sense in one dependency but imo this looks great! |
|
While porting the code I noticed that we compute the row-group statistics based on the page statistics. Thus, I think that |
jorgecarleitao
changed the title
WriteOptions
jorgecarleitao
changed the title
WriteOptionscompression from WriteOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the explicit compression setting in
WriteOptions.It was somewhat confusing as the pages still needed to be appropriately
compressed, and limiting as it forced the same value for the whole file.
Let me know if I missed the motivation behind this field!