Added compression options/levels for GZIP and BROTLI codecs. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sets the default GZIP compression == 6, as this is the default within miniz_oxide. * brotli quality is kept the same, as no default was listed with the brotli rust crate. This is a breaking API change, however it is an extension of the previous breaking change to zstd levels.
|
I left the other compression types alone:
Finally, in |
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 74.27% 74.35% +0.08%
==========================================
Files 78 78
Lines 3553 3576 +23
==========================================
+ Hits 2639 2659 +20
- Misses 914 917 +3
Continue to review full report at Codecov.
|
TurnOfACard
commented
Apr 28, 2022
| /// Compression levels must be valid (i.e. be acceptable for [`zstd::compression_level_range`]) | ||
| #[cfg(feature = "zstd")] | ||
| pub fn try_new(level: i32) -> Result<Self, Error> { | ||
| let compression_range = zstd::compression_level_range(); |
There was a problem hiding this comment.
I removed this call so the trait could be used across the different compression types
jorgecarleitao
changed the title
|
Awesome PR. Thanks a lot @TurnOfACard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change. However, it is an extension of the previous breaking change to zstd levels.