Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new_with_page_meta to PageReader #136

Merged
merged 8 commits into from
May 5, 2022

Conversation

ygf11
Copy link
Contributor

@ygf11 ygf11 commented May 1, 2022

closes #135

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #136 (6efd634) into main (fa6fa3c) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files          78       78           
  Lines        3576     3588   +12     
=======================================
+ Hits         2659     2668    +9     
- Misses        917      920    +3     
Impacted Files Coverage Δ
src/read/mod.rs 82.14% <ø> (ø)
src/read/page/stream.rs 76.08% <90.00%> (-1.19%) ⬇️
src/read/page/reader.rs 92.85% <90.90%> (-0.48%) ⬇️
src/read/page/indexed_reader.rs 55.12% <100.00%> (+1.18%) ⬆️
src/read/stream.rs 59.52% <0.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6fa3c...6efd634. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great. I left some comments on it.

I think we should introduce this for the other page readers (async and filtered), so that we have a consistent API across them.

src/read/page/reader.rs Outdated Show resolved Hide resolved
src/read/page/reader.rs Outdated Show resolved Hide resolved
src/read/page/reader.rs Outdated Show resolved Hide resolved
src/read/page/reader.rs Outdated Show resolved Hide resolved
src/read/page/reader.rs Show resolved Hide resolved
@ygf11
Copy link
Contributor Author

ygf11 commented May 3, 2022

I think we should introduce this for the other page readers (async and filtered), so that we have a consistent API across them.

Yes, they should be consistent.

Is there anything else besides get_page_stream and IndexedPageReader?

ygf11 and others added 5 commits May 3, 2022 15:32
@jorgecarleitao
Copy link
Owner

Is there anything else besides get_page_stream and IndexedPageReader?

Note, that is it 👍

@jorgecarleitao jorgecarleitao merged commit 47edd88 into jorgecarleitao:main May 5, 2022
@jorgecarleitao jorgecarleitao added the feature A new feature label May 5, 2022
@jorgecarleitao
Copy link
Owner

thanks a lot again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass only necessary data when create PageReader
3 participants