-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new_with_page_meta to PageReader #136
Conversation
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 74.35% 74.35%
=======================================
Files 78 78
Lines 3576 3588 +12
=======================================
+ Hits 2659 2668 +9
- Misses 917 920 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks great. I left some comments on it.
I think we should introduce this for the other page readers (async
and filtered), so that we have a consistent API across them.
Yes, they should be consistent. Is there anything else besides |
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Note, that is it 👍 |
thanks a lot again! |
closes #135