Fixed error in compressing lz4raw with large offsets #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in the implementation compared to the rest of the implementations.
The situation is as follows:
L
B
bytes. We thus need to re-resize the buffer toL + B
b <= B
bytesWe resized the buffer to
B
bytes (instead ofB + L
). Thus, whenb > B - L
, the compression fails. This is more likely to happen whenL>>B
.In
V1
pages,L == 0
and thus this is not an issue. However, in V2 pages,L != 0
and we have a problem (compression errors)