Delay deserialization of dictionary pages #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate:
These are problematic because:
&[u8] -> this crate DictPage -> their format
. Becausethis crate DictPage -> their format
may depend on logical types, this has to be done on every array (instead of once per dictionary page).This PR
This PR modifies the page readers to output the
enum Page
instead of aDataPage
, no longer attaching a decoded dictionary page (Arc<dyn DictPage>
) to every page. Users must now handle the deserialization of the dictionary page themselves by matching the enum variants. This allows them to&[u8] -> this crate DictPage -> their in-memory format
by&[u8] -> their in-memory format
async
context.The change to the example and integration tests shows the required migration