Fixed error in rle decoding #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
commented
Dec 12, 2022
| @@ -54,7 +54,7 @@ fn read_next<'a, 'b>(decoder: &'b mut Decoder<'a>, remaining: usize) -> Result<S | |||
| }); | |||
| let value = u32::from_le_bytes(bytes); | |||
| if additional == 1 { | |||
| State::Single(value) | |||
| State::Single(Some(value)) | |||
There was a problem hiding this comment.
Because we have this small number optimization, the stop iteration call indicated by returning None was never triggered.
By keeping a Option<u32> state we keep track of this and return None once a value is already taken.
|
Thanks! Released in v0.17.1 through backporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes jorgecarleitao/arrow2#1327
@jorgecarleitao could we patch this one? I think it is serious enough.
I'd like to add a test for this one, but I don't (yet) know parquet enough to to setup these conditions