Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to write to async writers. #35

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Aug 10, 2021

This PR adds support to write to AsyncWrite + AsyncSeek (+ Unpin + Send).

The need for AsyncSeek is due to a current limitation of thrift that does not report how many bytes were written in their protocols. This implementation only calls seek of SeekFrom::Current(0) before and after writing to compute how much bytes were written between the calls.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #35 (4c9d153) into main (eca414b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   67.08%   67.10%   +0.01%     
==========================================
  Files          63       63              
  Lines        3482     3481       -1     
==========================================
  Hits         2336     2336              
+ Misses       1146     1145       -1     
Impacted Files Coverage Δ
src/write/column_chunk.rs 0.00% <ø> (ø)
src/write/dyn_iter.rs 0.00% <ø> (ø)
src/write/file.rs 100.00% <ø> (ø)
src/write/page.rs 0.00% <ø> (ø)
src/write/mod.rs 91.93% <100.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca414b...4c9d153. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 450c99d into main Aug 25, 2021
@jorgecarleitao jorgecarleitao deleted the async_write branch August 25, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants