Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in reading zero-width bit from hybrid RLE. #53

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Sep 29, 2021

When the decoder has a zero bit width, it means that it is always the same value (0). We did not take this edge case into account.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #53 (e8da2c1) into main (4179260) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   67.48%   67.56%   +0.07%     
==========================================
  Files          64       64              
  Lines        3485     3493       +8     
==========================================
+ Hits         2352     2360       +8     
  Misses       1133     1133              
Impacted Files Coverage Δ
src/encoding/hybrid_rle/decoder.rs 92.15% <ø> (ø)
src/encoding/hybrid_rle/mod.rs 87.93% <100.00%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4179260...e8da2c1. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 272b200 into main Sep 29, 2021
@jorgecarleitao jorgecarleitao deleted the fix_error branch September 29, 2021 07:06
@aptr322
Copy link

aptr322 commented Sep 29, 2021

@jorgecarleitao Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants