Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added writing reduced statistics for FixedLenByteArray #55

Merged

Conversation

potter420
Copy link
Contributor

Hello,

I wrote a small changes to write module to write reduced statistics for FixedLenByteArray as well.

To address the issue here

I don't know how to write macro properly yet so I just simply copy over the function reduce_binary

@codecov-commenter
Copy link

Codecov Report

Merging #55 (554ec05) into main (e79e784) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   67.54%   67.12%   -0.43%     
==========================================
  Files          64       64              
  Lines        3494     3516      +22     
==========================================
  Hits         2360     2360              
- Misses       1134     1156      +22     
Impacted Files Coverage Δ
src/write/statistics.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79e784...554ec05. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e6bd672 into jorgecarleitao:main Oct 2, 2021
@jorgecarleitao jorgecarleitao added the enhancement New feature or request label Oct 2, 2021
@jorgecarleitao jorgecarleitao changed the title Add writing reduced statistics for FixedLenByteArray Added writing reduced statistics for FixedLenByteArray Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants