Fixed delta-bitpacked mini-block decoding #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input bytes were never consumed while going to the next mini-block, leading to some very interesting values. I couldn't find anything with enough data in `parquet-testing` so I wrote a small test case. It works for all the files I've tested created by the `parquet` crate, though.
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 67.56% 67.38% -0.18%
==========================================
Files 64 64
Lines 3493 3523 +30
==========================================
+ Hits 2360 2374 +14
- Misses 1133 1149 +16
Continue to review full report at Codecov.
|
|
Thanks a lot for finding and fixing this. Looks great. 💯 |
jorgecarleitao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input bytes were never consumed while going to the next mini-block,
leading to some very interesting values.
I couldn't find anything with enough data in
parquet-testingso I wrote a small test case. It works for all the files I've tested createdby the
parquetcrate, though.