-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified API to write files #78
Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 69.30% 67.76% -1.55%
==========================================
Files 66 68 +2
Lines 3691 3800 +109
==========================================
+ Hits 2558 2575 +17
- Misses 1133 1225 +92
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Would be convenient to have an interface for writing Parquet files that implements Sink
but I'd be happy to put in an issue for that since it's likely out of scope of this PR.
Thanks @dexterduck ! You mean |
0d71bcb
to
188ce32
Compare
561cc79
to
18509a0
Compare
18509a0
to
8169067
Compare
@jorgecarleitao yep! It's a relatively minor thing but it would be nice to have an interface that implements |
Thanks for your review, @dexterduck and suggestion. I agree. Would you be able to work on the |
Sure, I'll give it a shot and put a PR in! |
This simplifies the API to write a file by giving the user more control over when to emit a Row group to write.
Thanks to /u/dexterduck for the feedback on reddit that led to this PR!