Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file offset #81

Merged

Conversation

barrotsteindev
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #81 (23984b1) into main (2c516c7) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   67.79%   67.52%   -0.27%     
==========================================
  Files          68       69       +1     
  Lines        3797     3812      +15     
==========================================
  Hits         2574     2574              
- Misses       1223     1238      +15     
Impacted Files Coverage Δ
src/metadata/row_metadata.rs 41.17% <0.00%> (-7.10%) ⬇️
src/write/mod.rs 92.40% <ø> (ø)
src/write/row_group.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c516c7...23984b1. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e8a0c35 into jorgecarleitao:main Feb 5, 2022
@jorgecarleitao jorgecarleitao added the enhancement New feature or request label Feb 5, 2022
@jorgecarleitao jorgecarleitao changed the title Rowgroup file offset 2 Added file offset Feb 5, 2022
@jorgecarleitao
Copy link
Owner

Thanks again, @barrotsteindev !

@barrotsteindev
Copy link
Contributor Author

Related to #52
My pleasure @jorgecarleitao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants